Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for prelu dynamo converter #2972

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add support for prelu dynamo converter #2972

merged 1 commit into from
Jul 8, 2024

Conversation

HolyWu
Copy link
Contributor

@HolyWu HolyWu commented Jun 30, 2024

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 30, 2024
@github-actions github-actions bot requested a review from zewenli98 June 30, 2024 15:39
zewenli98
zewenli98 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HolyWu
Copy link
Contributor Author

HolyWu commented Jul 2, 2024

@zewenli98 Thanks. Could you approve the workflows to run the CI?

@peri044 peri044 merged commit bb405b0 into pytorch:main Jul 8, 2024
55 of 61 checks passed
cehongwang pushed a commit that referenced this pull request Jul 8, 2024
@HolyWu @cehongwang
Add support for prelu dynamo converter (#2972)
15430ca
@HolyWu HolyWu deleted the prelu branch July 8, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zewenli98 zewenli98 zewenli98 approved these changes

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HolyWu @zewenli98 @facebook-github-bot @peri044