Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix use_cache flag #2965

Merged
merged 1 commit into from
Jul 1, 2024
Merged

chore: fix use_cache flag #2965

merged 1 commit into from
Jul 1, 2024

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Jun 28, 2024

Description

Fix use_cache flag usage. We could actually remove use_cache flag and use cache if a user provides cache_file. But this would affect the existing workflows and backwards compatibility. So, changes are intentionally minimal here.

Fixes #2960

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@narendasan
Copy link
Collaborator

Better not change APIs in the legacy system, the fix seems fine

@peri044 peri044 merged commit d4b5e40 into main Jul 1, 2024
58 of 64 checks passed
cehongwang pushed a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] DataLoaderCalibrator cache check
3 participants