Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gather converter #2905

Merged
merged 1 commit into from
Jun 14, 2024
Merged

gather converter #2905

merged 1 commit into from
Jun 14, 2024

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented Jun 11, 2024 •
edited
Loading

No description provided.

@apbose apbose self-assigned this Jun 11, 2024
@apbose apbose marked this pull request as draft June 11, 2024 06:32
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 11, 2024
@github-actions github-actions bot requested a review from gs-olive June 11, 2024 06:33
@apbose apbose removed the request for review from gs-olive June 11, 2024 06:33
@apbose apbose force-pushed the gather_converter branch 5 times, most recently from 8648fe1 to f98d2ee Compare June 13, 2024 07:19
@apbose apbose marked this pull request as ready for review June 13, 2024 16:51
@apbose apbose requested review from zewenli98 and chohk88 June 13, 2024 16:51
zewenli98
zewenli98 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apbose apbose merged commit 0cb03a7 into main Jun 14, 2024
38 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zewenli98 zewenli98 zewenli98 approved these changes

@chohk88 chohk88 Awaiting requested review from chohk88

Assignees

@apbose apbose

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apbose @zewenli98 @facebook-github-bot