Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry pick of #2805 #2851

Merged
merged 1 commit into from
May 21, 2024
Merged

chore: cherry pick of #2805 #2851

merged 1 commit into from
May 21, 2024

Conversation

bowang007
Copy link
Collaborator

Description

Cherry pick a previous commit.

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 17, 2024
@github-actions github-actions bot requested a review from narendasan May 17, 2024 21:12
@bowang007 bowang007 requested a review from peri044 May 17, 2024 21:13
peri044
peri044 approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 93e8f29 into main May 21, 2024
37 of 54 checks passed
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@bowang007 @laikhtewari
chore: cherry pick of #2805 (#2851)
2a8645c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees
No one assigned
Labels
cla signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bowang007 @peri044 @facebook-github-bot