Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for aten.pixel_unshuffle dynamo converter #2696

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add support for aten.pixel_unshuffle dynamo converter #2696

merged 1 commit into from
Apr 5, 2024

Conversation

HolyWu
Copy link
Contributor

@HolyWu HolyWu commented Mar 17, 2024

Description

Fixes #2694

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 17, 2024
@gs-olive gs-olive requested a review from zewenli98 March 18, 2024 17:12
zewenli98
zewenli98 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending on CI.

@HolyWu HolyWu requested a review from zewenli98 March 23, 2024 05:42
@narendasan narendasan merged commit 7d30714 into pytorch:main Apr 5, 2024
19 of 23 checks passed
@HolyWu HolyWu deleted the pixel_unshuffle branch April 6, 2024 04:43
peri044 pushed a commit that referenced this pull request Apr 19, 2024
@HolyWu @peri044
Add support for aten.pixel_unshuffle dynamo converter (#2696)
4bb60f3
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@HolyWu @laikhtewari
Add support for aten.pixel_unshuffle dynamo converter (#2696)
b5618aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan Awaiting requested review from narendasan

@zewenli98 zewenli98 Awaiting requested review from zewenli98

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

↔ [Converter] Add support for torch.ops.aten.pixel_unshuffle.default in Torch-TensorRT
4 participants
@HolyWu @zewenli98 @narendasan @facebook-github-bot