Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add cmake missing source file ref for core_lowering.passes #2672

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Arktische
Copy link
Contributor

@Arktische Arktische commented Mar 6, 2024

Description

Add missing source file core/lowering/passes/unpack_scaled_dot_product_attention.cpp to core/lowering/passes/CMakeLists.txt. If not do so, when building shared library torchtrt will fail due to missing reference to function UnpackScaledDotProductAttention.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have added the relevant labels to my PR in so that relevant reviewers are notified
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: core Issues re: The core compiler labels Mar 6, 2024
@github-actions github-actions bot requested a review from gs-olive March 6, 2024 04:49
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@narendasan narendasan merged commit a2e76a8 into pytorch:main Mar 22, 2024
10 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants