Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add additional BN native converter #2446

Merged
merged 2 commits into from
Nov 9, 2023
Merged

chore: add additional BN native converter #2446

merged 2 commits into from
Nov 9, 2023

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Nov 8, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@peri044 peri044 added the WIP Work is in progress, pull request should not be merged yet label Nov 8, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests labels Nov 8, 2023
@peri044 peri044 marked this pull request as draft November 8, 2023 18:56
@github-actions github-actions bot requested a review from apbose November 8, 2023 18:56
github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@zewenli98 zewenli98 mentioned this pull request Nov 8, 2023
Closed
gs-olive
gs-olive reviewed Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a minor comment and the # type: ignore[misc] can be removed, as suggested by @zewenli98

py/torch_tensorrt/dynamo/lowering/_decomposition_groups.py Outdated Show resolved Hide resolved
@gs-olive gs-olive linked an issue Nov 8, 2023 that may be closed by this pull request
↔ [Converter] Add support for torch.ops.aten._native_batch_norm_legit_no_training.default in Torch-TensorRT #2444
Closed
@peri044
chore: add additional BN native converter
bca187d 
Signed-off-by: Dheeraj Peri <[email protected]>

chore: address review comments

Signed-off-by: Dheeraj Peri <[email protected]>

chore: updates

Signed-off-by: Dheeraj Peri <[email protected]>
@peri044 peri044 marked this pull request as ready for review November 8, 2023 21:09
github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

zewenli98
zewenli98 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the CI looks problematic.

gs-olive
gs-olive approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gs-olive
Copy link
Collaborator

gs-olive commented Nov 8, 2023

CI is likely unrelated to this change - it seems to be a mismatch between the Torch version used to build Torch-TensorRT and the version of Torch in the environment.

github-actions[bot]
github-actions bot approved these changes Nov 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@peri044 peri044 merged commit 2893d6e into main Nov 9, 2023
15 of 19 checks passed
peri044 added a commit that referenced this pull request Nov 9, 2023
@peri044
chore: add additional BN native converter (#2446)
bfa1bdf 
Signed-off-by: Dheeraj Peri <[email protected]>
peri044 added a commit that referenced this pull request Nov 10, 2023
@peri044
chore: add additional native BN converter (cherry-pick of #2446) (#2452)
9feb800 
Signed-off-by: Dheeraj Peri <[email protected]>
@peri044 peri044 deleted the bn_fix branch November 15, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zewenli98 zewenli98 zewenli98 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@gs-olive gs-olive gs-olive approved these changes

@apbose apbose Awaiting requested review from apbose

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests WIP Work is in progress, pull request should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

↔ [Converter] Add support for torch.ops.aten._native_batch_norm_legit_no_training.default in Torch-TensorRT
4 participants
@peri044 @gs-olive @zewenli98 @facebook-github-bot