Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add issue template for Story #1936

Merged
merged 1 commit into from
May 22, 2023
Merged

feat: Add issue template for Story #1936

merged 1 commit into from
May 22, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented May 19, 2023 •
edited
Loading

Description

  • Create template for proposing new stories, which include multiple issues/features/PRs all related under a key central theme
  • Fix numbering in bug report template
  • Add default "Story" label

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
feat: Add issue template for Story
52370df 
- Create template for proposing new stories, which include multiple
issues/features/PRs all related under a key central theme
- Fix numbering in bug report template
@gs-olive gs-olive requested a review from narendasan May 19, 2023 21:12
@gs-olive gs-olive self-assigned this May 19, 2023
narendasan
narendasan approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 520f62a into pytorch:main May 22, 2023
@gs-olive gs-olive deleted the new_story_issue branch May 22, 2023 16:08
narendasan pushed a commit that referenced this pull request May 30, 2023
@gs-olive @narendasan
feat: Add issue template for Story (#1936)
453266b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot