Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upgrade main to TRT 8.6, CUDA 11.8, CuDNN 8.8, Torch Dev #1852

Merged
merged 6 commits into from
May 12, 2023
Merged

fix: Upgrade main to TRT 8.6, CUDA 11.8, CuDNN 8.8, Torch Dev #1852

merged 6 commits into from
May 12, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Apr 21, 2023 •
edited
Loading

Description

  • Upgrade versions, make required code edits for functionality and coverage for tests and CI
  • Improve documentation of READMEs across repository
  • Add in test cases previously disabled due to dependency issues

Type of change

  • Version Upgrades
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label Apr 21, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: build system Issues re: Build system component: core Issues re: The core compiler component: runtime component: tests Issues re: Tests labels Apr 21, 2023
@gs-olive gs-olive removed the request for review from narendasan April 21, 2023 21:17
@gs-olive gs-olive force-pushed the stack_upgrade_cuda_trt branch 4 times, most recently from 8e03fd9 to baf61e0 Compare April 22, 2023 05:07
@gs-olive gs-olive mentioned this pull request Apr 22, 2023
Closed
@gs-olive gs-olive self-assigned this Apr 24, 2023
@gs-olive gs-olive changed the title fix: Upgrade main to TRT 8.6, CUDA 11.8, Torch Dev fix: Upgrade main to TRT 8.6, CUDA 11.8, CuDNN 8.8, Torch Dev Apr 24, 2023
@gs-olive gs-olive force-pushed the stack_upgrade_cuda_trt branch 4 times, most recently from 0541226 to 72f4f5e Compare April 25, 2023 16:38
@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label Apr 25, 2023
@gs-olive gs-olive marked this pull request as ready for review April 25, 2023 18:03
@gs-olive gs-olive force-pushed the stack_upgrade_cuda_trt branch 2 times, most recently from 3413a78 to ba93377 Compare April 27, 2023 00:06
gs-olive
gs-olive commented Apr 27, 2023
View reviewed changes
py/setup.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the component: api [C++] Issues re: C++ API label Apr 28, 2023
@gs-olive gs-olive force-pushed the stack_upgrade_cuda_trt branch 4 times, most recently from 9122b93 to 76b93a6 Compare May 4, 2023 00:44
@gs-olive
fix: Upgrade main to TRT 8.6, CUDA 11.8, Torch Dev
5f86d5f 
- Upgrade versions, make required code edits for functionality and
coverage for tests and CI
@gs-olive gs-olive mentioned this pull request May 8, 2023
Closed
@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label May 9, 2023
@github-actions github-actions bot requested a review from yinghai May 9, 2023 01:24
@gs-olive gs-olive removed the request for review from yinghai May 12, 2023 17:57
@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label May 12, 2023
narendasan
narendasan approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit ac3ab77 into pytorch:main May 12, 2023
@gs-olive gs-olive deleted the stack_upgrade_cuda_trt branch May 12, 2023 22:18
@anandrajaraman anandrajaraman mentioned this pull request May 18, 2023
Closed
@narendasan narendasan mentioned this pull request May 22, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@peri044 peri044 Awaiting requested review from peri044

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [C++] Issues re: C++ API component: api [Python] Issues re: Python API component: build system Issues re: Build system component: core Issues re: The core compiler component: fx component: runtime component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gs-olive @narendasan @facebook-github-bot @peri044