Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bugfix in shape analysis for multi-GPU systems #1765

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Shape analysis code in partitioning defaults dry-run tensors to cuda:0 despite user-specified devices
  • This leads to errors about device casting for internal tensors, which users cannot cast
  • Add GPU-ID function arguments in functions to generate new tensors on the user-specified (or default) device

Fixes #1764

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
    • Verified locally [requires multi-GPU to test]
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

- Shape analysis code in partitioning defaults dry-run tensors to cuda:0
despite user-specified devices
- This leads to errors about device casting for internal tensors, which
users cannot cast
- Add GPU-ID function arguments in functions to generate new tensors on
the user-specified (or default) device
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit a4e4f77 into pytorch:main Mar 24, 2023
@gs-olive gs-olive deleted the partitioning_device_fix branch March 24, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Compilation of transformer models on non-cuda:0 devices fails
3 participants