-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX] Changes done internally at Facebook #1603
Conversation
2345bec2d694df51ddfa583b9a51fcec0b0ff656 Wei Wei <[email protected]> [fx2trt] add pass elapsed time in log a2b867b1dfa9bbc4c93cfefc44535d8e6db699b2 Shirong Wu <[email protected]> Add missing kwarg 383f43da4a3ece0457637a945c762b9eb5ac9e73 Janet Yang <[email protected]> [fx][acc_tracer] Fix "list indices must be integers or slices, not Node" issue during lowering 7dcb956d4297787614b9c2f31cbe7c7e9f4720db Andrew Or <[email protected]> [Quant][fx][bc-breaking] Add simpler BackendConfig pattern format 140b3f0c9474ba7d677dc121f739395cf2d87db3 Huamin Li <[email protected]> Update customized_fuse_pass in lower_setting.py 5cef3146e886f315d881af64fd4117054acebe8b Shirong Wu <[email protected]> Add TRT aten converter 6db5870f3c9b2e8c8c83854f7276979a027f78fd Shirong Wu <[email protected]> Enable skipped test 5f53e0776add2bd4ea810a2aa8f16bd426e38895 Shirong Wu <[email protected]> Enable explicit batch dim 8c250cafde9bc7bd18b59c91bb038673f7de4a10 Wei Wei <[email protected]> [aten2trt] add PT2.0 tracer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
Any idea what |
Also don't consider this gating for this PR getting merged but @apbose can you make sure to take a look at these so you know how the FX converter library is changing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the ROI custom op error seems legit.
This operator seems not existed in external version. I need to comment it out.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- py/torch_tensorrt/fx/test/converters/aten_op/test_cat_aten.py 2023-01-22 19:34:32.383167 +0000
+++ py/torch_tensorrt/fx/test/converters/aten_op/test_cat_aten.py 2023-01-22 19:34:50.014348 +0000
@@ -7,11 +7,11 @@
class TestCatConverter(DispatchTestCase):
@parameterized.expand(
[
("pos", 1),
- #("neg", -2), #Dynamo tracer issue
+ # ("neg", -2), #Dynamo tracer issue
]
)
def test_cat(self, _, dim):
class Cat(nn.Module):
def forward(self, x, y, z):
@@ -25,11 +25,11 @@
)
@parameterized.expand(
[
("pos", 1),
- #("neg", -2), #Dynamo tracer issue
+ # ("neg", -2), #Dynamo tracer issue
]
)
def test_cat_dynamic_shape(self, _, dim):
class Cat(nn.Module):
def forward(self, x, y):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right
2345bec2d694df51ddfa583b9a51fcec0b0ff656 Wei Wei [email protected] [fx2trt] add pass elapsed time in log a2b867b1dfa9bbc4c93cfefc44535d8e6db699b2 Shirong Wu [email protected] Add missing kwarg 383f43da4a3ece0457637a945c762b9eb5ac9e73 Janet Yang [email protected] [fx][acc_tracer] Fix "list indices must be integers or slices, not Node" issue during lowering 7dcb956d4297787614b9c2f31cbe7c7e9f4720db Andrew Or [email protected] [Quant][fx][bc-breaking] Add simpler BackendConfig pattern format 140b3f0c9474ba7d677dc121f739395cf2d87db3 Huamin Li [email protected] Update customized_fuse_pass in lower_setting.py 5cef3146e886f315d881af64fd4117054acebe8b Shirong Wu [email protected] Add TRT aten converter 6db5870f3c9b2e8c8c83854f7276979a027f78fd Shirong Wu [email protected] Enable skipped test 5f53e0776add2bd4ea810a2aa8f16bd426e38895 Shirong Wu [email protected] Enable explicit batch dim 8c250cafde9bc7bd18b59c91bb038673f7de4a10 Wei Wei [email protected] [aten2trt] add PT2.0 tracer
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: