Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add aten::full_like evaluator #1584

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix: Add aten::full_like evaluator #1584

merged 1 commit into from
Jan 17, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Complete set of required operators for full coverage of HuggingFace T5-base model (https://huggingface.co/t5-base)
  • Add evaluator for full_like with sufficient generality to double as functional operator for ones_like and zeros_like, with minor additions
  • Add thorough testing to ensure type and shape inheritance for returned tensors agrees with documentation

Documentation of full_like: https://pytorch.org/docs/stable/generated/torch.full_like.html

Fixes #1583

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: tests Issues re: Tests labels Jan 11, 2023
@gs-olive gs-olive self-assigned this Jan 11, 2023
@gs-olive gs-olive force-pushed the full_like_evaluator branch 2 times, most recently from bc0f1a1 to 50bb44d Compare January 13, 2023 01:29
@gs-olive
fix: Add aten::full_like evaluator
0aaeecb 
- Complete set of required operators for full coverage of HuggingFace
T5 model
- Add evaluator for `full_like` with sufficient generality to double as
functional operator for `ones_like` and `zeros_like`, with minor
additions
- Add thorough testing to ensure type and shape inheritance for returned
tensors agrees with documentation
@gs-olive gs-olive requested a review from peri044 January 17, 2023 17:45
peri044
peri044 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 66d4aa9 into pytorch:main Jan 17, 2023
@gs-olive gs-olive deleted the full_like_evaluator branch January 17, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@gs-olive gs-olive

Labels
cla signed component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Compilation failure for HuggingFace T5-base Model
3 participants
@gs-olive @peri044 @facebook-github-bot