Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]Canonicalize aten::multiply to aten::mul #1517

Merged

Conversation

mfeliz-cruise
Copy link
Contributor

Description

Add a trivial pass to convert aten::multiply to aten::mul https://pytorch.org/docs/stable/generated/torch.multiply.html.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests labels Dec 2, 2022
@mfeliz-cruise
Copy link
Contributor Author

Looks like the linter is broken @peri044 Error: Version 3.9.4 with arch x64 not found

@narendasan
Copy link
Collaborator

Looks like the linter is broken @peri044 Error: Version 3.9.4 with arch x64 not found

Should be fixed in master if you rebase

@mfeliz-cruise mfeliz-cruise force-pushed the michael.feliz/canonicalize_multiply branch from 808bcf4 to 43a11c9 Compare December 2, 2022 23:03
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit b7ceedf into pytorch:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants