Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: torch.std and torch.var support multi-dimensional reductions #1395

Merged
merged 5 commits into from
Oct 12, 2022
Merged

fix: torch.std and torch.var support multi-dimensional reductions #1395

merged 5 commits into from
Oct 12, 2022

Commits on Oct 8, 2022

  1. Augment current tests to reproduce error generating bug with standard… 

    … dev / variance lowering
    @gs-olive
    gs-olive committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    39246e6 View commit details
    Browse the repository at this point in the history

  2. fix: Ensure torch.std (and torch.var) support multiple dimensions 

    - Refactor IR code to avoid the use of select, for which only
single-dimension support exists currently
- Update formula in Bessel's correction (unbiased) case
- Include regression tests to catch multi-dimensional indexing errors
    @gs-olive
    gs-olive committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    c65ef4e View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Merge branch 'pytorch:master' into multi_dim_var_bugfix

    @gs-olive
    gs-olive authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    6a54c2b View commit details
    Browse the repository at this point in the history

  2. Improved comments on IR for UnpackVar function

    @gs-olive
    gs-olive committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    5bebd9c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'multi_dim_var_bugfix' of https://github.com/gs-olive/Te… 

    …nsorRT into multi_dim_var_bugfix
    @gs-olive
    gs-olive committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    49ff751 View commit details
    Browse the repository at this point in the history