refactor: naming cleanup

Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
pytorch · Jul 15, 2020 · 0e3a684 · 0e3a684
1 parent 6cee04d
commit 0e3a684
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/core/conversion/BUILD b/core/conversion/BUILD
@@ -14,7 +14,7 @@ cc_library(
     ],
     srcs = [
         "conversion.cpp",
-        "conversion_blacklist.cpp",
+        "conversion_ignorelist.cpp",
         "InterfaceTypes.cpp"
     ],
     deps = [

diff --git a/core/conversion/conversion.cpp b/core/conversion/conversion.cpp
@@ -11,8 +11,8 @@ namespace trtorch {
 namespace core {
 namespace conversion {
 
-// Defined in core/conversion/conversion_blacklist.cpp
-bool isNodeConversionBlacklisted(const torch::jit::Node* n);
+// Defined in core/conversion/conversion_ignorelist.cpp
+bool isNodeConversionIgnored(const torch::jit::Node* n);
 
 bool OpSupported(const torch::jit::Node* n) {
     return evaluators::shouldEvalAtConversionTime(n) || converters::node_is_convertable(n);
@@ -302,7 +302,7 @@ void ConvertBlockToNetDef(ConversionCtx* ctx, const torch::jit::Block* b, Conver
 
     for (const auto n : nodes) {
         bool to_eval = evaluators::shouldEvalAtConversionTime(n);
-        bool blacklisted = isNodeConversionBlacklisted(n);
+        bool ignored = isNodeConversionIgnored(n);
         if (n->kind() == torch::jit::prim::Loop) {
             EvaluateLoopBlock(ctx, n);
         } else if (n->kind() == torch::jit::prim::If) {
@@ -317,16 +317,16 @@ void ConvertBlockToNetDef(ConversionCtx* ctx, const torch::jit::Block* b, Conver
                 }
                 ctx->AssociateValueAndIValue(n->output(0), eval.value());
             }
-        } else if (!blacklisted) {
+        } else if (!ignored) {
             // Should error out if something fails
             AddLayer(ctx, n);
         } else {
             std::string reason = "";
             if (to_eval) {
                 reason += " (to be evaluated)";
             }
-            if (blacklisted) {
-                reason += " (explicitly blacklisted)";
+            if (ignored) {
+                reason += " (explicitly ignored)";
             }
             LOG_DEBUG(ctx->logger,
                       "Skipping Node: " << util::node_info(n) << reason);

diff --git a/core/conversion/conversion_blacklist.cpp → core/conversion/conversion_ignorelist.cpp b/core/conversion/conversion_blacklist.cpp → core/conversion/conversion_ignorelist.cpp
@@ -28,7 +28,7 @@ const std::unordered_set<std::string>& get_non_convertable_nodes() {
     return nonconvertable_nodes;
 }
 
-bool isNodeConversionBlacklisted(const torch::jit::Node* n) {
+bool isNodeConversionIgnored(const torch::jit::Node* n) {
     auto kind = n->kind();
     auto convertableIt = get_non_convertable_nodes().find(kind.toQualString());
     if (convertableIt == get_non_convertable_nodes().end()) {