Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call scalar_type #3394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

slyfox3
Copy link

@slyfox3 slyfox3 commented Nov 19, 2024

Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/482

As all argument already should be scalar types

Reviewed By: q10

Differential Revision: D65310552

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 1540960
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/673cf6c00520da0008aada32
😎 Deploy Preview https://deploy-preview-3394--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65310552

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65310552

@slyfox3
Copy link
Author

slyfox3 commented Nov 19, 2024

Are the failed checks still working properly? Build errors are from python3.9: link

In file included from /github/home/miniconda/envs/build_binary/lib/python3.9/site-packages/torch/include/c10/util/Float8_e5m2.h:17:
/github/home/miniconda/envs/build_binary/lib/python3.9/site-packages/torch/include/c10/util/Half.h:175:10: error: reference to __host__ function '_cvtsh_ss' in __host__ __device__ function
  175 |   return _cvtsh_ss(h);

Summary:
X-link: facebookresearch/FBGEMM#482

As all argument already should be scalar types

Reviewed By: q10

Differential Revision: D65310552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants