Skip to content

Commit

Permalink
Add -Wimplicit-fallthrough to fbgemm (#1802)
Browse files Browse the repository at this point in the history
Summary:
Ensure that we don't accidentally fallthrough switch statements.

Pull Request resolved: #1802

Reviewed By: q10, brad-mengchi

Differential Revision: D46377516

fbshipit-source-id: 509fd7007fb90d8dbe8d4522eaf052acc8a15bd4
  • Loading branch information
r-barnes authored and facebook-github-bot committed Jun 6, 2023
1 parent 90e6f83 commit e9d7e3e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ else(MSVC)
string(APPEND CMAKE_CXX_FLAGS " -Wextra")
string(APPEND CMAKE_CXX_FLAGS " -Werror")
string(APPEND CMAKE_CXX_FLAGS " -Wno-deprecated-declarations")
string(APPEND CMAKE_CXX_FLAGS " -Wimplicit-fallthrough")
target_compile_options(fbgemm_avx2 PRIVATE
"-m64" "-mavx2" "-mf16c" "-mfma")
target_compile_options(fbgemm_avx512 PRIVATE
Expand Down

0 comments on commit e9d7e3e

Please sign in to comment.