Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add react tweet embed and tweet data #266

Merged
merged 7 commits into from
Oct 8, 2023
Merged

add react tweet embed and tweet data #266

merged 7 commits into from
Oct 8, 2023

Conversation

bhansa
Copy link
Member

@bhansa bhansa commented Oct 6, 2023

No description provided.

@netlify
Copy link

netlify bot commented Oct 6, 2023 •
edited
Loading

✅ Deploy Preview for inpycon2023 ready!

Name Link
🔨 Latest commit 01b8250
🔍 Latest deploy log https://app.netlify.com/sites/inpycon2023/deploys/652286ade5ae500008fe21d5
😎 Deploy Preview https://deploy-preview-266--inpycon2023.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bhansa bhansa requested review from inovizz and RajatRajdeep October 6, 2023 12:30
@bhansa bhansa changed the title [wip] add react tweet embed and tweet data add react tweet embed and tweet data Oct 6, 2023
RajatRajdeep
RajatRajdeep reviewed Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@RajatRajdeep RajatRajdeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in desktop view, but the animation is not smooth in mobile view.
Attached the clip which shows the issue.

Screen.Recording.2023-10-06.at.21.57.49.mov

@bhansa
Copy link
Member Author

bhansa commented Oct 8, 2023

Added CSS animation instead of react slick, custom slider made in css for smooth scroll and less layout shift.

@bhansa bhansa merged commit de3778d into pythonindia:main Oct 8, 2023
@bhansa bhansa mentioned this pull request Oct 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RajatRajdeep RajatRajdeep RajatRajdeep approved these changes

@inovizz inovizz Awaiting requested review from inovizz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhansa @RajatRajdeep