Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
SimpleCamera
fromarcade.camera
's__init__.py
simple_camera.py
file itselfWhy
TL;DR: We'd have to rewrite
SimpleCamera
again + Discord discussion suggests nobody actually wants SimpleCamera aroundIt's Not Actually 2.6 Compatible
The current
SimpleCamera
isn't API-compatible with 2.6. Instead, it's a rewrite of a rewrite started before 3.0. See the blue forks on this timeline (credit goes to @DigiDuncan):Green is
development
, yellow appears to be WIP codeNothing Actually Uses It
arcade.camera
Camera2D.from_raw_data
is the best porting optionTL;DR: Add migration guide showing how to convert code to use the class method
SimpleCamera
Fails to Delivermove_to
/update
methodsupdate
doesn't accept a time stepOther compatibility approaches were disliked
The following options were disliked in Discord discussion:
Camera
which acts like 2.6 but logs deprecation warning to consoleCamera
import raises anImportError
on use + links a migration guide