-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stubs for xtea library #9740
stubs for xtea library #9740
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jelle Zijlstra <[email protected]>
Note that stub_uploader is different from stubtest. stub_uploader will not be happy with |
This comment has been minimized.
This comment has been minimized.
@hauntsaninja My understanding is that
|
Improved typing from JelleZijlstra's review. Co-authored-by: Jelle Zijlstra <[email protected]>
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Yeah, I think it would be a little challenging to add Three alternative options are:
In all cases, we're very happy to review the stubs themselves and are grateful for your contribution of them! :-) |
Ok, contributing the stubs to |
Adds stubs for the xtea encyption library.
I think that this is ready to review, unless CI catches something I've missed.