Update fpdf2 stubs to 2.6.1 #9546
Conversation
stubs/fpdf2/fpdf/fpdf.pyi
Outdated
| # The following definition crashes stubtest. | ||
| # def set_encryption( | ||
| # self, | ||
| # owner_password: str, | ||
| # user_password: str | None = None, | ||
| # encryption_method: EncryptionMethod | str = ..., | ||
| # permissions: AccessPermission = ..., | ||
| # encrypt_metadata: bool = False, | ||
| # ) -> None: ... |
There was a problem hiding this comment.
This needs further investigation for which I didn't have time yet.
There was a problem hiding this comment.
I just ran this against stubtest HEAD and this seems to fix it. I'll update the comment.
This comment has been minimized.
This comment has been minimized.
|
I think we'll need a pytype release that includes google/pytype@829c589 if you want to keep the string default values — or you could take them out for now, and add them back when we have the new pytype release |
This comment has been minimized.
This comment has been minimized.
|
@rchen152 Is there a timeline for the next pytype release? This is non-critical, since we can easily work around the issue, but if a release is due soon, I would rather wait. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Waygood <[email protected]>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry for the delay! (Yesterday was MLK day here.) We usually aim to do one pytype release a week. It's a manual process, so there's no fixed schedule. Yesterday's nightly tests were clean, so I can cut a release right now, actually. |
That would be great, if possible! It would help unblock #9501 |
|
Done! The new pytype version is 2023.01.17. |
Amazing, thank you! |
Closes #9542