-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Any subclassing in setuptools #9460
Fix Any subclassing in setuptools #9460
Conversation
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
||
_Reporter: TypeAlias = Any # really docutils.utils.Reporter | ||
from ..cmd import Command | ||
|
||
# Only defined if docutils is installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is still true. I think it has value if someone wonders why its in the stub but not in their runtime.
I sort of wonder if we shouldn't just delete the But all that's for another issue/PR discussion. |
Remove the need for subclassing `Any`
Remove the need for subclassing `Any`
Reference the docutils stub.
As far as I understand, there's no issue with this if docutils isn't installed. And gives proper type when it is.
Fixes 3 subclassing errors (the same error in setuptools, pyinstaller and Pygments stubs)
Ref: #9491