Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for dockerfile-parse #9305

Merged
merged 7 commits into from
Nov 30, 2022
Merged

Add stubs for dockerfile-parse #9305

merged 7 commits into from
Nov 30, 2022

Conversation

pyhedgehog
Copy link
Contributor

No description provided.

@github-actions

This comment has been minimized.

…d of typing.Literal + reimport wuth "X as X" all imported values
@github-actions

This comment has been minimized.

requirements-tests.txt Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments and suggestions below.

In general, we also prefer to import things like Mapping, MutableMapping, etc. from collections.abc rather than typing, wherever possible.

stubs/dockerfile-parse/dockerfile_parse/constants.pyi Outdated Show resolved Hide resolved
stubs/dockerfile-parse/dockerfile_parse/constants.pyi Outdated Show resolved Hide resolved
stubs/dockerfile-parse/dockerfile_parse/parser.pyi Outdated Show resolved Hide resolved
stubs/dockerfile-parse/dockerfile_parse/parser.pyi Outdated Show resolved Hide resolved
stubs/dockerfile-parse/dockerfile_parse/parser.pyi Outdated Show resolved Hide resolved
stubs/dockerfile-parse/dockerfile_parse/util.pyi Outdated Show resolved Hide resolved
stubs/dockerfile-parse/dockerfile_parse/util.pyi Outdated Show resolved Hide resolved
stubs/dockerfile-parse/dockerfile_parse/util.pyi Outdated Show resolved Hide resolved
stubs/dockerfile-parse/dockerfile_parse/util.pyi Outdated Show resolved Hide resolved
stubs/dockerfile-parse/dockerfile_parse/util.pyi Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've pushed to your branch to fix a few minor style issues (we usually prefer to import things from collections.abc instead of typing wherever possible). Will merge once the CI's finished :)

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 87d2683 into python:main Nov 30, 2022
hauntsaninja pushed a commit to python/mypy that referenced this pull request Dec 20, 2022
Removals from `stubinfo.py`:
- `atomicwrites` is archived and deprecated at runtime; stubs were
removed from typeshed in python/typeshed#8925
- `attrs` has had inline types for a very long time now
- `chardet` recently cut a release with inline types; typeshed's stubs
were marked obsolete in python/typeshed#9318
- `cryptography` has had inline types for a very long time now; the only
reason why it's still in typeshed is because other typeshed packages
need `types-cryptography` as a dependency, and our testing
infrastructure therefore can't currently cope with it being removed from
typeshed.
- `emoji` recently cut a release bundling stubs with the runtime
package; typeshed's stubs were marked obsolete in
python/typeshed#9051
- `termcolor` recently cut a release with inline types; typeshed's stubs
were marked obsolete in python/typeshed#8746
- `prettytable` recently cut a release with inline types; typeshed's
stubs were marked obsolete in
python/typeshed#9023

Additions:
- Stubs for `Xlib` were added in
python/typeshed#9279
- Stubs for `consolemenu` were added in
python/typeshed#8820
- Stubs for `dockerfile_parse` were added in
python/typeshed#9305
- Stubs for `flask_migrate` were added in
python/typeshed#8967
- Stubs for `paho.mqtt` were added in
python/typeshed#8853
- Stubs for `pycocotools` were added in
python/typeshed#9086
- Stubs for many `pywin32` modules were added in
python/typeshed#8825, and multiple follow-up PRs
- Stubs for `pyscreeze` were added in
python/typeshed#8823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants