Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests: Allow session headers to be of type None #7773

Merged
merged 14 commits into from
May 16, 2022
+40 −18
Merged

requests: Allow session headers to be of type None #7773

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d9ca9a7
Allow session headers to be of type None
janrito May 3, 2022
249ce7c
Revert "Allow session headers to be of type None"
janrito May 4, 2022
0602cc3
Allow for bytes in header value
janrito May 4, 2022
b1ad88d
Add _HeadersMapping alias, which allows bytes as well as strings as h…
janrito May 4, 2022
9996858
Add _HeadersMappingUpdate alias, which allows for an empty mapping as…
janrito May 4, 2022
3368ce6
fix type annotation rather than assignment
janrito May 4, 2022
0e8ff7e
`MutableMapping[str, str | bytes] -> MutableMapping[str, str] | Muta…
janrito May 4, 2022
b5ec834
str | bytes | None
janrito May 6, 2022
6f7eb28
reverse bytes type on session headers
janrito May 9, 2022
f9aaf0c
Revert "reverse bytes type on session headers"
janrito May 16, 2022
0d80bdf
Response header dict is always `str`
janrito May 16, 2022
072c537
PreparedRequests cast headers to native strings as well
janrito May 16, 2022
f189735
Fix `CaseInsensitiveDict[str | bytes]` invariance
janrito May 16, 2022
ccb434d
Revert "Fix `CaseInsensitiveDict[str | bytes]` invariance"
janrito May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stubs/requests/requests/sessions.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ _Verify: TypeAlias = bool | str

class Session(SessionRedirectMixin):
__attrs__: Any
headers: CaseInsensitiveDict[str]
headers: CaseInsensitiveDict[str | None]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in https://docs.python-requests.org/en/latest/user/quickstart/#custom-headers , header values can also be bytestring.

Suggested change
headers: CaseInsensitiveDict[str | None]
headers: CaseInsensitiveDict[str | bytes | None]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I think I added None to the wrong place. We want to allow str or bytes on actual headers, but None only on updates

auth: _Auth | None
proxies: _TextMapping
hooks: _Hooks
Expand Down