Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve open overloads when mode is a literal union #7428

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Improve open overloads when mode is a literal union #7428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,7 +1308,7 @@ def open(
def open(
file: _OpenFile,
mode: OpenBinaryMode,
buffering: int,
buffering: int = ...,
encoding: None = ...,
errors: None = ...,
newline: None = ...,
Expand Down
2 changes: 1 addition & 1 deletion stdlib/importlib/abc.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ if sys.version_info >= (3, 9):
@overload
@abstractmethod
def open(
self, mode: OpenBinaryMode, buffering: int, encoding: None = ..., errors: None = ..., newline: None = ...
self, mode: OpenBinaryMode, buffering: int = ..., encoding: None = ..., errors: None = ..., newline: None = ...
) -> BinaryIO: ...
# Fallback if mode is not specified
@overload
Expand Down
2 changes: 1 addition & 1 deletion stdlib/os/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ def fdopen(
def fdopen(
fd: int,
mode: OpenBinaryMode,
buffering: int,
buffering: int = ...,
encoding: None = ...,
errors: None = ...,
newline: None = ...,
Expand Down
2 changes: 1 addition & 1 deletion stdlib/pathlib.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class Path(PurePath):
# Buffering cannot be determined: fall back to BinaryIO
@overload
def open(
self, mode: OpenBinaryMode, buffering: int, encoding: None = ..., errors: None = ..., newline: None = ...
self, mode: OpenBinaryMode, buffering: int = ..., encoding: None = ..., errors: None = ..., newline: None = ...
) -> BinaryIO: ...
# Fallback if mode is not specified
@overload
Expand Down
2 changes: 1 addition & 1 deletion stubs/aiofiles/aiofiles/threadpool/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def open(
def open(
file: _OpenFile,
mode: OpenBinaryMode,
buffering: int,
buffering: int = ...,
encoding: None = ...,
errors: None = ...,
newline: None = ...,
Expand Down