Treat validators as classes #7035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuli
reviewed
Jan 25, 2022
| @@ -4,18 +4,21 @@ from typing import Any, ClassVar | |||
|
|
|||
| from ._utils import URIDict | |||
|
|
|||
| _Schema = Any | |||
There was a problem hiding this comment.
This can apparently be a boolean or Mapping[str, str], or at least it is expected to have a .get() method similar to mappings.
There was a problem hiding this comment.
I didn't have time to investigate this in depth and didn't want to make assumptions, but if you have determined the type I can include it.
Co-authored-by: Akuli <[email protected]>
Akuli
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7028