Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for ldap3 #6561

Merged
merged 17 commits into from
Dec 10, 2021
Merged

Add stubs for ldap3 #6561

merged 17 commits into from
Dec 10, 2021

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Dec 10, 2021

Best reviewed commit by commit. First commit is stubgen + black + isort - imports.

@Akuli
Copy link
Collaborator

Akuli commented Dec 10, 2021

(env) akuli@akuli-desktop:~/typeshed/env/lib/python3.9/site-packages/ldap3$ grep -r 'except ImportError'
utils/tls_backport.py:except ImportError:
utils/log.py:except ImportError:  # NullHandler not present in Python < 2.7
utils/ciDict.py:except ImportError:
utils/uri.py:except ImportError:
utils/ntlm.py:                except ImportError:
protocol/sasl/kerberos.py:except ImportError:
protocol/sasl/kerberos.py:    except ImportError:
protocol/sasl/kerberos.py:    except ImportError:
protocol/formatters/formatters.py:except ImportError:
extend/standard/PersistentSearch.py:except ImportError:  # Python 2
extend/microsoft/persistentSearch.py:except ImportError:  # Python 2
core/tls.py:except ImportError:
core/tls.py:except ImportError:
core/tls.py:except ImportError:
core/server.py:except ImportError:
core/server.py:except ImportError:
strategy/asyncStream.py:except ImportError:  # Python 2
strategy/reusable.py:except ImportError:  # Python 2
strategy/base.py:except ImportError:
abstract/entry.py:except ImportError:
__init__.py:    except ImportError:

Maybe we should check if the # Python 2 lines (maybe others too) need manual cleanup.

@srittau
Copy link
Collaborator Author

srittau commented Dec 10, 2021

I'm sure there is quite a lot of Python 2 cleanup possible.

Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: reviewed the beginning of 8effa8e and everything before it

stubs/ldap3/ldap3/core/connection.pyi Outdated Show resolved Hide resolved
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing 8effa8e

stubs/ldap3/ldap3/core/connection.pyi Outdated Show resolved Hide resolved
stubs/ldap3/ldap3/core/connection.pyi Outdated Show resolved Hide resolved
stubs/ldap3/ldap3/core/connection.pyi Outdated Show resolved Hide resolved
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing done

stubs/ldap3/ldap3/utils/tls_backport.pyi Outdated Show resolved Hide resolved
stubs/ldap3/ldap3/utils/tls_backport.pyi Show resolved Hide resolved
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't read the first commit.

@srittau srittau merged commit 74ecc29 into python:master Dec 10, 2021
@srittau srittau deleted the ldap3 branch December 10, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants