Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mypy excludes #6230

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Remove mypy excludes #6230

merged 1 commit into from
Nov 8, 2021

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Nov 3, 2021

The list hasn't been used since 2016 and I don't think we should add files that mypy can't parse anyway at this point.

This simplifies mypy_test.py quite a bit.

@srittau
Copy link
Collaborator Author

srittau commented Nov 3, 2021

Depends on #6229.

@JelleZijlstra
Copy link
Member

I merged the other PR, going to mark this one as ready.

@JelleZijlstra JelleZijlstra marked this pull request as ready for review November 7, 2021 23:13
@JelleZijlstra
Copy link
Member

There is a merge conflict that's beyond my current pay grade.

@srittau srittau force-pushed the remove-mypy-excludes branch from 1ec9f2f to 467c9af Compare November 7, 2021 23:33
@srittau
Copy link
Collaborator Author

srittau commented Nov 7, 2021

I force pushed this after a rebase against master. Basically all commits except the last were from #6229, so this just reapplied the last commit. Ready for review.

@Akuli Akuli merged commit 3876587 into python:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants