More types for tkinter.Treeview #5584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to just use |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: porcupine (https://github.com/Akuli/porcupine.git)
+ porcupine/plugins/autocomplete.py:142: error: unused "type: ignore" comment
+ porcupine/plugins/autocomplete.py:143: error: unused "type: ignore" comment
+ porcupine/plugins/autocomplete.py:192: error: unused "type: ignore" comment
+ porcupine/plugins/autocomplete.py:202: error: unused "type: ignore" comment
+ porcupine/plugins/autocomplete.py:209: error: unused "type: ignore" comment
+ porcupine/plugins/autocomplete.py:228: error: unused "type: ignore" comment
+ porcupine/plugins/autocomplete.py:230: error: unused "type: ignore" comment
+ porcupine/plugins/directory_tree.py:154: error: unused "type: ignore" comment
+ porcupine/plugins/directory_tree.py:173: error: unused "type: ignore" comment
+ porcupine/plugins/directory_tree.py:197: error: unused "type: ignore" comment
+ porcupine/plugins/directory_tree.py:219: error: unused "type: ignore" comment
+ porcupine/plugins/directory_tree.py:230: error: unused "type: ignore" comment
+ porcupine/plugins/directory_tree.py:271: error: unused "type: ignore" comment
+ porcupine/plugins/directory_tree.py:286: error: unused "type: ignore" comment
+ porcupine/plugins/directory_tree.py:340: error: unused "type: ignore" comment
+ porcupine/plugins/pluginmanager.py:133: error: unused "type: ignore" comment
+ porcupine/plugins/pluginmanager.py:136: error: unused "type: ignore" comment
|
srittau
approved these changes
Jun 6, 2021
This was referenced Jun 10, 2021
Akuli
added a commit
to Akuli/typeshed
that referenced
this pull request
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a bit unsure about
_TreeviewItemId:str. Is type alias preffered? Tkinter stubs have several other type aliases too, such as_Color, but they make more sense: they are used in many places, and they might change if someone wants to use instances of a custom class as colors._TreeviewItemId | Literal[""], but I could use a comment instead.