Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redis] replaces _Str with _Value as variable info #4281

Merged
merged 1 commit into from
Jun 27, 2020
Merged

[redis] replaces _Str with _Value as variable info #4281

merged 1 commit into from
Jun 27, 2020

Conversation

vishalkuo
Copy link
Contributor

Per discussion here: #4278

We should use a more descriptive variable name for redis values since these can be ints or floats instead of just strings

srittau
srittau approved these changes Jun 26, 2020
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelleZijlstra JelleZijlstra merged commit 986eff0 into python:master Jun 27, 2020
@vishalkuo vishalkuo deleted the redis-3 branch June 28, 2020 22:43
@Akuli Akuli mentioned this pull request Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishalkuo @srittau @JelleZijlstra