Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_codecs: fix various issues #3649

Merged
merged 5 commits into from
Jan 23, 2020
Merged

_codecs: fix various issues #3649

merged 5 commits into from
Jan 23, 2020

Conversation

hauntsaninja
Copy link
Collaborator

  • mark positional-only args as such
  • fix utf_16_ex_decode and utf_32_ex_decode (missing positional byteorder parameter)
  • fix default value of charmap_encode
  • fix availability of charbuffer_encode
  • improve consistency of naming for positional-only args

@hauntsaninja
Copy link
Collaborator Author

Also seems like codecs.pyi should probably import from _codecs, but we'll save that for another time

srittau
srittau approved these changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible.

@srittau srittau merged commit edd1ec8 into python:master Jan 23, 2020
@hauntsaninja hauntsaninja deleted the codecs3 branch January 24, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauntsaninja @srittau