builtins.pow: improve annotation #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
requested changes
Jan 23, 2020
stdlib/2/__builtin__.pyi
Outdated
| def pow(__x: float, __y: float, __z: float) -> float: ... | ||
| if sys.version_info >= (3, 8): | ||
| @overload | ||
| def pow(base: int, exp: int, mod: Optional[int] = ...) -> int: ... |
There was a problem hiding this comment.
Needs to return Any per previous comment. E.g. pow(3, -1) returns a float. It makes sense to use another overload for the case where mod is an int, since then only int can be returned. (Affects both branches.)
There was a problem hiding this comment.
Oh of course. Sorry about that, total mental lapse
srittau
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.