subprocess: Fix return type of check_output. #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check_output's return type can be str if universal_newlines=True.
| @@ -58,7 +58,7 @@ def check_output(args: Union[str, Sequence[str]], | |||
| creationflags: int = ..., | |||
| restore_signals: bool = ..., | |||
| start_new_session: bool = ..., | |||
| pass_fds: Any = ...) -> bytes: ... | |||
| pass_fds: Any = ...) -> Any: ... | |||
There was a problem hiding this comment.
how about Union[str, bytes] ?
There was a problem hiding this comment.
Disadvantages of using Union - python/mypy#1693.
sharmaeklavya2
added a commit
to sharmaeklavya2/rcvr
that referenced
this pull request
Jul 13, 2016
mypy is currently broken and gives false errors on devel/lister.py. See python/typeshed#348.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_output's return type can bestrifuniversal_newlines=True.