Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of pow to make it more restrictive. #286

Closed
wants to merge 2 commits into from
Closed

Fix return type of pow to make it more restrictive. #286

wants to merge 2 commits into from

Conversation

johnthagen
Copy link
Contributor

Fixes #285.

@matthiaskramm
Copy link
Contributor

Thanks for the PR! Could you fix the 2.7 version, as well?

@JukkaL
Copy link
Contributor

JukkaL commented Jun 10, 2016

As mentioned elsewhere this will potentially be bad for mypy users.
On Fri, Jun 10, 2016 at 21:43 Matthias Kramm [email protected]
wrote:

Thanks for the PR! Could you fix the 2.7 version, as well?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#286 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABDnx1hUef2JHOA81lKC6icAR3_OP9Aaks5qKcxZgaJpZM4IzTlW
.

@johnthagen
Copy link
Contributor Author

@matthiaskramm Fixed 2.7 as well.

@matthiaskramm
Copy link
Contributor

Jukka, I leave it up to you to merge this or not - pytype is fine with Union[float, int], but pytype overrides __builtin__.pyi with its own pyi, hence is unaffected by this change.

@gvanrossum
Copy link
Member

Let's close this unmerged. I'll leave @285 open though, since it has important discussion.

@gvanrossum gvanrossum closed this Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants