Fix stub for SpooledTemporaryFile #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the moment, inheriting from |
stdlib/3/tempfile.pyi
Outdated
| prefix: Optional[str] = ..., dir: Optional[str] = ... | ||
| ) -> None: ... | ||
| def rollover(self) -> None: ... | ||
| def __enter__(self) -> 'SpooledTemporaryFile': ... |
There was a problem hiding this comment.
Quoting is not necessary in stubs.
I copied the abstract methods from |
|
Could you have a look at the build failures? It seems that imports of |
|
Fixed, thanks for the pointers. |
srittau
requested changes
Nov 19, 2018
|
CI is failing, because |
srittau
approved these changes
Nov 20, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2431.
Not sure if inheriting from
IO[Any]is the right way to do it, because in reality the class does not, but it implements the protocol. What is the proper way to indicate that?Also updates some argument types to include
Optionalexplicitly, to match the definition.