Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codecs.StreamRecoder attributes #13291

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

tungol
Copy link
Contributor

@tungol tungol commented Dec 24, 2024

That these were missing from the stubs was being silenced by this part of the common allowlist:

# See comments in file. List out methods that are delegated by __getattr__ at runtime.
# Used to make the relevant class satisfy BinaryIO interface.
codecs.StreamReaderWriter.\w+
codecs.StreamRecoder.\w+

But these weren't part of the group of errors being described, which are errors about things being in the stubs that don't appear to exist at runtime.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit 1f0a86c into python:main Dec 24, 2024
63 checks passed
@tungol tungol deleted the codecs branch December 24, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants