-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a couple missing tkinter things #13149
Conversation
The comment said this will cause lots of mypy problems, let's see what.
This comment has been minimized.
This comment has been minimized.
I see; the problem is that |
This comment has been minimized.
This comment has been minimized.
Too bad. Mypy and pyright have different behavior here. Given this: label = tkinter.Label()
reveal_type(label.config) Mypy shows the more specific overload that created on
but pyright stays with the base class annotation and says:
Given that, I don't know if there's a way to add |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
not sure if this actually matters to any type checkers? Seems more accurate though.
It doesn't, and we prefer leaving out the |
This comment has been minimized.
This comment has been minimized.
Good to know |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The comment said this will cause lots of mypy problems, let's see what.