Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyinstaller to 6.11.* #12911

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Oct 27, 2024

Closes #12821

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also new constants in PyInstaller/depend/analysis.py:

HOOK_PRIORITY_BUILTIN_HOOKS = -2000  # Built-in hooks. Lowest priority.
HOOK_PRIORITY_CONTRIBUTED_HOOKS = -1000  # Hooks from pyinstaller-hooks-contrib package.
HOOK_PRIORITY_UPSTREAM_HOOKS = 0  # Hooks provided by packages themselves, via entry-points.
HOOK_PRIORITY_USER_HOOKS = 1000  # User-supplied hooks (command-line / spec file). Highest priority.

@Avasam
Copy link
Collaborator Author

Avasam commented Oct 27, 2024

There are also new constants in PyInstaller/depend/analysis.py:

Some modules, like PyInstaller.building.*, PyInstaller.depend.* and PyInstaller.lib.* are purposefully minimally annotated and only contains stuff that is either explicitely documented, or because a type is exposed by public modules.

Those constants are not documented, and seem to be meant for internal use only (you shouldn't try to change the priority group of your hooks)

stubs/pyinstaller/PyInstaller/building/build_main.pyi

# Referenced in: https://pyinstaller.org/en/stable/hooks.html#PyInstaller.utils.hooks.get_hook_config
# Not to be imported during runtime, but is the type reference for hooks and analysis configuration
# Also referenced in https://pyinstaller.org/en/stable/spec-files.html
# Not to be imported during runtime, but is the type reference for spec files which are executed as python code
class Analysis(Target):

stubs/pyinstaller/PyInstaller/depend/analysis.pyi

# https://pyinstaller.org/en/stable/hooks.html#the-pre-safe-import-module-psim-api-method
# The documentation explicitly mentions that "Normally you do not need to know about the module-graph."
# However, some PyiModuleGraph typed class attributes are still documented as existing in imphookapi.

stubs/pyinstaller/@tests/stubtest_allowlist.txt

# Most modules are not meant to be used, yet are not marked as private

@srittau srittau merged commit c225ac7 into python:main Oct 27, 2024
48 checks passed
@Avasam Avasam deleted the Bump-pyinstaller-to-6.11.- branch October 27, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants