Replace Any with Incomplete in distutils #12842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 tasks
srittau
requested changes
Oct 18, 2024
Avasam
commented
Oct 18, 2024
Avasam
commented
Oct 18, 2024
Co-authored-by: Sebastian Rittau <[email protected]>
Avasam
commented
Oct 18, 2024
Avasam
commented
Oct 18, 2024
srittau
approved these changes
Oct 18, 2024
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Delgan
reviewed
Oct 18, 2024
| @@ -101,7 +101,8 @@ def setup( | |||
| include_dirs: list[str] = ..., | |||
| password: str = ..., | |||
| fullname: str = ..., | |||
| **attrs, | |||
| # Custom Distributions could accept more params | |||
| **attrs: Any, | |||
There was a problem hiding this comment.
Just came across this commit while investigating why pyright started warning that Type of "setup" is partially unknown since release of 1.1.375 a few weeks ago. Hopefully, this slight addition should fix it.
There was a problem hiding this comment.
Sounds like it would, yeah.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards #9550
I'm working on providing distutils stubs directly from setuptools (for Python 3.12+ support). And I wanted to start from as clean a slate as possible when copying typeshed's stubs. It includes not using
Anywhere not necessary.