[fpdf2] fix link type to support internal links #12695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods with the
link
argument can take an internal link (created viaadd_link
which returns anint
) or an external URL as per their docstring.The type hint only allows for
str
.link
already has the correct type hint:typeshed/stubs/fpdf2/fpdf/fpdf.pyi
Lines 343 to 345 in a94c927
add_link
returns anint
:typeshed/stubs/fpdf2/fpdf/fpdf.pyi
Line 341 in a94c927
This PR changes the type hint to
str | int
.