Complete coverage for the qrcode package

[mjpieters]

This PR covers all of the project. This library is somewhat underdocumented so
I erred on the side of covering all modules with public names.

Without this PR, the hints are partly broken; we have experienced these specific issues in production code:

• The QRCode() overload fails to match when trying to use one of the qrcode.constants.ERROR_CORRECT_* constants for error_correction and providing an image_factory value, due to the use of Literal[]
• The RoundedModuleDrawer radius_ratio argument is incorrectly typed as int (probably based on the default value, it should be a float).

[srittau]

Thanks! Not a complete review, but we require Anys to be documented (either using a comment or using an appropriate type alias). I noticed that you added Any annotations to a few kwargs arguments which are - I suspect - forwarded to another function. In this case, we could copy the arguments over (or leave kwargs unannotated for now).

[mjpieters]

Thanks! Not a complete review, but we require Anys to be documented (either using a comment or using an appropriate type alias). I noticed that you added Any annotations to a few kwargs arguments which are - I suspect - forwarded to another function. In this case, we could copy the arguments over (or leave kwargs unannotated for now).

I'll review these again and document where I can. I certainly may have missed some forwarded calls in this project.

However, there are some bad practices in the codebase, like a ABCs with an empty (non-abstract) __init__ method with **kwargs and no types. I think I may just remove these from the annotations instead.

[srittau]

However, there are some bad practices in the codebase, like a ABCs with an empty (non-abstract) init method with **kwargs and no types. I think I may just remove these from the annotations instead.

You could either remove them if you think that no valid code should call __init__ with arguments, or you could use _typeshed.Unused to mark that fact.

[mjpieters]

You could either remove them if you think that no valid code should call __init__ with arguments, or you could use _typeshed.Unused to mark that fact.

The project isn't that well structured, I am not confident enough to say it'll never be called with arguments. So I removed it from the type hints altogether.

[srittau]

Thanks, a few notes below, mostly around using IO and its sub-classes. These are semi-deprecated in typeshed, especially in argument types, since these types are not protocols and very wide.

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉