Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump waitress to 3.0.* #11803

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Bump waitress to 3.0.* #11803

merged 2 commits into from
Apr 22, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Apr 21, 2024

Closes #11363

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
srittau
srittau requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One additional thing I noticed: _bool_marker was removed from waitress.adjustments and the Adjustments.clear_untrusted_proxy_headers field.

@Avasam
Copy link
Collaborator Author

Avasam commented Apr 22, 2024

Thanks! I forgot about it when splitting off from #11796
I just double checked there wasn't any other forgotten removed private name.

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 7858e60 into python:main Apr 22, 2024
42 checks passed
@Avasam Avasam deleted the Bump-waitress-to-3.0.- branch April 22, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avasam @srittau