Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flake8-pyi to 24.4.1 #11791

Merged
merged 2 commits into from
Apr 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,6 @@ jobs:
- run: uv pip install -r requirements-tests.txt --system
- run: python ./tests/check_typeshed_structure.py

new-syntax:
name: Ensure new syntax usage
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.12"
- run: ./tests/check_new_syntax.py

pytype:
name: Run pytype against the stubs
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ repos:
- id: flake8
additional_dependencies:
- "flake8-noqa==1.4.0" # must match requirements-tests.txt
- "flake8-pyi==24.4.0" # must match requirements-tests.txt
- "flake8-pyi==24.4.1" # must match requirements-tests.txt
types: [file]
types_or: [python, pyi]
- repo: meta
Expand Down
2 changes: 1 addition & 1 deletion requirements-tests.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
black==24.3.0 # must match .pre-commit-config.yaml
flake8==7.0.0 # must match .pre-commit-config.yaml
flake8-noqa==1.4.0 # must match .pre-commit-config.yaml
flake8-pyi==24.4.0 # must match .pre-commit-config.yaml
flake8-pyi==24.4.1 # must match .pre-commit-config.yaml
mypy==1.9.0
pre-commit-hooks==4.5.0 # must match .pre-commit-config.yaml
pyright==1.1.358
Expand Down
4 changes: 0 additions & 4 deletions scripts/runtests.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ def main() -> None:

print("\nRunning check_typeshed_structure.py...")
check_structure_result = subprocess.run([sys.executable, "tests/check_typeshed_structure.py"])
print("\nRunning check_new_syntax.py...")
check_new_syntax_result = subprocess.run([sys.executable, "tests/check_new_syntax.py"])

strict_params = _get_strict_params(path)
print(f"\nRunning Pyright ({'stricter' if strict_params else 'base' } configs) for Python {python_version}...")
Expand Down Expand Up @@ -180,7 +178,6 @@ def main() -> None:
[
pre_commit_result.returncode,
check_structure_result.returncode,
check_new_syntax_result.returncode,
pyright_returncode,
mypy_result.returncode,
getattr(stubtest_result, "returncode", 0),
Expand All @@ -207,7 +204,6 @@ def main() -> None:
that the autofixes did sensible things."""
)
print("Check structure:", _SUCCESS if check_structure_result.returncode == 0 else _FAILED)
print("Check new syntax:", _SUCCESS if check_new_syntax_result.returncode == 0 else _FAILED)
if pyright_skipped:
print("Pyright:", _SKIPPED)
else:
Expand Down
2 changes: 0 additions & 2 deletions tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ tests the stubs with [mypy](https://github.com/python/mypy/)
stubs, guarding against accidental regressions.
- `tests/check_typeshed_structure.py` checks that typeshed's directory
structure and metadata files are correct.
- `tests/check_new_syntax.py` contains linter-like checks to ensure
that certain code conventions are followed.
- `tests/stubtest_stdlib.py` checks standard library stubs against the
objects at runtime.
- `tests/stubtest_third_party.py` checks third-party stubs against the
Expand Down
48 changes: 0 additions & 48 deletions tests/check_new_syntax.py

This file was deleted.