Simplify protoc install in protobuf generation scripts #11785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hesitant to use something like https://pypi.org/project/protoc-wheel-0/, but then I found https://pypi.org/project/grpcio-tools/ to run protoc.
This simplifies the protoc installation logic by installing the protoc executable from PyPI (using an official source) rather than downloading and unzipping a platform-specific zipped distribution from GitHub.
I also added the protoc (aka libprotoc) version to the extra-description. And wrapped the long description string.
Its also one step closer to running the scripts directly in Windows (using Git bash), I think all I'd need to add is a python vs python3 condition.