Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify protoc install in protobuf generation scripts #11785

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Apr 18, 2024

I was hesitant to use something like https://pypi.org/project/protoc-wheel-0/, but then I found https://pypi.org/project/grpcio-tools/ to run protoc.

This simplifies the protoc installation logic by installing the protoc executable from PyPI (using an official source) rather than downloading and unzipping a platform-specific zipped distribution from GitHub.

I also added the protoc (aka libprotoc) version to the extra-description. And wrapped the long description string.

Its also one step closer to running the scripts directly in Windows (using Git bash), I think all I'd need to add is a python vs python3 condition.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't claim to understand what's going on here, but I'm sure you know what you're doing.

@Avasam
Copy link
Collaborator Author

Avasam commented Apr 21, 2024

@srittau I've updated the description to be a bit more clear about what I'm doing here.

@srittau srittau merged commit 1017c52 into python:main Apr 21, 2024
44 checks passed
@Avasam Avasam deleted the simplify-protoc-install branch April 21, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants