Add docker-py stubs #11749
Merged
Add docker-py stubs #11749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
So the mypy_primer errors seem justified. Some invalid imports (they work at runtime due to side-effects but are not allowed). In addition in |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
There is already some precedent here: docker/docker-py#2796 |
I'm aware of this issue. There was no real progress since 3 years... |
|
Stubtest still has a few complaints. |
This comment has been minimized.
This comment has been minimized.
srittau
approved these changes
Apr 12, 2024
|
Diff from mypy_primer, showing the effect of this PR on open source code: prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/utilities/dockerutils.py:98: error: Cannot find implementation or library stub for module named "docker" [import-not-found]
+ src/prefect/utilities/dockerutils.py:431: error: Name "docker.Image" is not defined [name-defined]
- src/prefect/infrastructure/container.py:47: error: Cannot find implementation or library stub for module named "docker" [import-not-found]
- src/prefect/infrastructure/container.py:49: error: Cannot find implementation or library stub for module named "docker.models.containers" [import-not-found]
+ src/prefect/infrastructure/container.py:508: error: Argument 1 to "_build_container_settings" of "DockerContainer" has incompatible type "Coroutine[Any, Any, DockerClient]"; expected "DockerClient" [arg-type]
+ src/prefect/infrastructure/container.py:508: note: Maybe you forgot to use "await"?
+ src/prefect/infrastructure/container.py:510: error: Argument 1 to "_should_pull_image" of "DockerContainer" has incompatible type "Coroutine[Any, Any, DockerClient]"; expected "DockerClient" [arg-type]
+ src/prefect/infrastructure/container.py:510: note: Maybe you forgot to use "await"?
+ src/prefect/infrastructure/container.py:512: error: Argument 1 to "_pull_image" of "DockerContainer" has incompatible type "Coroutine[Any, Any, DockerClient]"; expected "DockerClient" [arg-type]
+ src/prefect/infrastructure/container.py:512: note: Maybe you forgot to use "await"?
+ src/prefect/infrastructure/container.py:514: error: Argument 1 to "_create_container" of "DockerContainer" has incompatible type "Coroutine[Any, Any, DockerClient]"; expected "DockerClient" [arg-type]
+ src/prefect/infrastructure/container.py:514: note: Maybe you forgot to use "await"?
- src/prefect/infrastructure/container.py:520: error: "Coroutine[Any, Any, Any]" has no attribute "networks" [attr-defined]
+ src/prefect/infrastructure/container.py:520: error: "Coroutine[Any, Any, DockerClient]" has no attribute "networks" [attr-defined]
- src/prefect/infrastructure/container.py:637: error: Cannot find implementation or library stub for module named "docker.errors" [import-not-found]
+ src/prefect/infrastructure/container.py:520: note: Maybe you forgot to use "await"?
+ src/prefect/infrastructure/container.py:666: error: Incompatible types in assignment (expression has type "None", variable has type "Container") [assignment]
+ src/prefect/infrastructure/container.py:678: error: Missing return statement [return]
+ src/prefect/infrastructure/container.py:687: error: Incompatible types in "yield" (actual type "Container", expected type "None") [misc]
+ src/prefect/infrastructure/container.py:713: error: Incompatible types in "yield" (actual type "Container", expected type "None") [misc]
+ src/prefect/infrastructure/container.py:719: error: Incompatible types in "yield" (actual type "Container", expected type "None") [misc]
- src/prefect/cli/dev.py:405: error: Cannot find implementation or library stub for module named "docker" [import-not-found]
- src/prefect/cli/dev.py:406: error: Cannot find implementation or library stub for module named "docker.models.containers" [import-not-found]
paasta (https://github.com/yelp/paasta)
+ paasta_tools/utils.py:76: error: Module "docker" has no attribute "Client"; maybe "APIClient"? [attr-defined]
+ paasta_tools/utils.py:3490: error: Unexpected keyword argument "assert_hostname" for "kwargs_from_env" [call-arg]
dragonchain (https://github.com/dragonchain/dragonchain)
+ dragonchain/job_processor/contract_job.py:251:16: error: Module has no attribute "errors" [attr-defined]
+ dragonchain/job_processor/contract_job.py:268:17: error: Module has no attribute "errors" [attr-defined]
+ dragonchain/job_processor/contract_job.py:280:16: error: Module has no attribute "errors" [attr-defined]
+ dragonchain/job_processor/contract_job_utest.py:251:13: error: "Callable[[Any, Optional[str], bool, KwArg(Any)], Any]" has no attribute "assert_called" [attr-defined]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.