Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openpyxl: Use duck typing for workbook sheets #11718

Merged
merged 6 commits into from
Apr 27, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Apr 4, 2024

Closes #11706

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting idea, but it feels like something that could well come back to bite us in the future. Any user who starts digging into the types is likely to end up confused.

I'm not completely opposed but I'd like to hear from other maintainers before we commit to this new technique.

This comment has been minimized.

1 similar comment

This comment has been minimized.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this. I was bitten by this recently when installing types-openpyxl. Maybe this "poor man's AnyOf" (python/typing#566) will help.

@srittau srittau merged commit bdf7502 into python:main Apr 27, 2024
43 checks passed
@Avasam Avasam deleted the workbook-sheets-duck-typing branch April 27, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openpyxl: no attribute "column_dimensions"
3 participants