Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stubsabot] Bump pyasn1 to 0.6.* #11664

Closed
wants to merge 1 commit into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

Release: https://pypi.org/pypi/pyasn1/0.6.0
Homepage: https://github.com/pyasn1/pyasn1
Repository: https://github.com/pyasn1/pyasn1
Changelog: https://pyasn1.readthedocs.io/en/latest/changelog.html
Diff: pyasn1/pyasn1@v0.5.1...v0.6.0

Stubsabot analysis of the diff between the two releases:

  • 0 public Python files have been added.
  • 0 files included in typeshed's stubs have been deleted.
  • 6 files included in typeshed's stubs have been modified or renamed: pyasn1/__init__.py, pyasn1/codec/ber/decoder.py, pyasn1/codec/ber/encoder.py, pyasn1/codec/native/decoder.py, pyasn1/codec/native/encoder.py, pyasn1/type/univ.py.
  • Total lines of Python code added: 404.
  • Total lines of Python code deleted: 5.

If stubtest fails for this PR:

  • Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
  • Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI

Release: https://pypi.org/pypi/pyasn1/0.6.0
Homepage: https://github.com/pyasn1/pyasn1
Repository: https://github.com/pyasn1/pyasn1
Changelog: https://pyasn1.readthedocs.io/en/latest/changelog.html
Diff: pyasn1/pyasn1@v0.5.1...v0.6.0

Stubsabot analysis of the diff between the two releases:
 - 0 public Python files have been added.
 - 0 files included in typeshed's stubs have been deleted.
 - 6 files included in typeshed's stubs have been modified or renamed: `pyasn1/__init__.py`, `pyasn1/codec/ber/decoder.py`, `pyasn1/codec/ber/encoder.py`, `pyasn1/codec/native/decoder.py`, `pyasn1/codec/native/encoder.py`, `pyasn1/type/univ.py`.
 - Total lines of Python code added: 404.
 - Total lines of Python code deleted: 5.

If stubtest fails for this PR:
- Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
- Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI
@github-actions github-actions bot added the bot: stubsabot 🤖 PRs created by stubsabot 🤖 label Mar 27, 2024
@AlexWaygood AlexWaygood reopened this Mar 27, 2024
@Avasam
Copy link
Collaborator

Avasam commented Mar 31, 2024

Any idea why stubtest isn't seeing the new classes here?
They're not ignored in the stubtest_allowlist and the METADATA.toml doesn't contain ignore_missing_stub = true

@AlexWaygood
Copy link
Member

Any idea why stubtest isn't seeing the new classes here?
They're not ignored in the stubtest_allowlist and the METADATA.toml doesn't contain ignore_missing_stub = true

If the runtime module defines __all__ and a symbol is not included in __all__, stubtest assumes there's a good reason for that so doesn't complain if the symbol is missing from the stub. I haven't looked through all of them, but it looks like some of these new classes weren't added to __all__

@Avasam Avasam mentioned this pull request Mar 31, 2024
@AlexWaygood AlexWaygood deleted the stubsabot/pyasn1 branch April 1, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: stubsabot 🤖 PRs created by stubsabot 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants