CONTRIBUTING.md: Add PR closing policy #11596
Conversation
Co-authored-by: Alex Waygood <[email protected]>
|
(My last commit only wraps long lines. It doesn't change the wording.) It seems like we're happy with this, but we could leave it open for a couple days or so in case other maintainers have something to say. |
| - An unambiguous bug in a type checker (i.e., a case where the | ||
| type checker is not implementing [the typing spec](https://typing.readthedocs.io/en/latest/spec/index.html)). | ||
| - A dependency on a typing PEP that is still under consideration. | ||
| - A pending change in a related project, such as stub-uploader. |
There was a problem hiding this comment.
This reminds me of the implementation-pending label. How should that interact with this policy and the "deferred" label?
There was a problem hiding this comment.
probably we don't really need both labels -- we could probably merge them into one :)
There was a problem hiding this comment.
We have too many labels anyway. They could use a good cleanup. But I agree that merging implementation-pending into deferred seems like an easy first step.
There was a problem hiding this comment.
the project and project-discussion labels could also probably be merged
There was a problem hiding this comment.
I guess the idea of "implementation-pending" is that we're specifically waiting for a third-party library we're stubbing to release their implementation. That's maybe a little different from "deferred", but not sure it's worth a separate label.
Co-authored-by: Avasam <[email protected]>
Co-authored-by: Avasam <[email protected]>
Closes #11583