-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uv
for installing requirements dynamically in stubtest_third_party.py
#11531
Conversation
Seems like |
Ouch, I'm surprised they haven't fixed that yet since Python 3.12 doesn't install setuptools into venvs by default anymore? |
the Failed to install
error: Failed to download and build: playsound==1.3.0
Caused by: Failed to build: playsound==1.3.0
Caused by: Build backend failed to determine extra requires with `build_wheel()`:
--- stdout:
--- stderr:
Traceback (most recent call last):
File "<string>", line 14, in <module>
File "/Users/alexw/Library/Caches/uv/.tmpRKpAih/.venv/lib/python3.12/site-packages/setuptools/build_meta.py", line 325, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/alexw/Library/Caches/uv/.tmpRKpAih/.venv/lib/python3.12/site-packages/setuptools/build_meta.py", line 295, in _get_build_requires
self.run_setup()
File "/Users/alexw/Library/Caches/uv/.tmpRKpAih/.venv/lib/python3.12/site-packages/setuptools/build_meta.py", line 487, in run_setup
super().run_setup(setup_script=setup_script)
File "/Users/alexw/Library/Caches/uv/.tmpRKpAih/.venv/lib/python3.12/site-packages/setuptools/build_meta.py", line 311, in run_setup
exec(code, locals())
File "<string>", line 6, in <module>
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/inspect.py", line 1282, in getsource
lines, lnum = getsourcelines(object)
^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/inspect.py", line 1264, in getsourcelines
lines, lnum = findsource(object)
^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/inspect.py", line 1093, in findsource
raise OSError('could not get source code')
OSError: could not get source code |
…eclared build-time dependencies
…d/typeshed into stubtest-3rd-party-uv
Roundup of the failuresBuild-time failures (not solvable without changes to the upstream packages and/or uv)
Runtime failures (these can be solved by installing setuptools into the environment before each package's stubtest run, like I did with my latest commit):
|
While the performance improvements would obviously be nice, this doesn't sound as if uv was really production ready, at least not for our purposes. I'd prefer not to add this additional headache at this point. |
Strictly speaking, these are all errors in third-party packages rather than |
If anything, it at least revealed some issues in the ecosystem that can be raised upstream. I can't blame |
👍 The only thing I'd add is that if packages fail to install with For example, here's
|
One thing we could do is start using |
Follow-up to #11517