Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow add tensorflow.saved_model #11439

Merged
merged 19 commits into from
Mar 13, 2024

Conversation

hoel-bagard
Copy link
Contributor

@hoel-bagard hoel-bagard commented Feb 18, 2024

Some of the stubs are taken from here.

All the members from the tensorflow.python module are causing the CI to fail since

from tensorflow import python
python.trackable.resource.CapturableResource  # Ok

import tensorflow
tensorflow.python.trackable.resource.CapturableResource  # AttributeError: module 'tensorflow' has no attribute 'python'

Should the whole tensorflow.python module be added to the allowlist ? I don't understand why the CI is fine with the other tensorflow.python modules that are already in the stubs.

This comment has been minimized.

@hoel-bagard hoel-bagard force-pushed the hoel/add_tf_saved_model branch 3 times, most recently from 6037e52 to 037c132 Compare February 18, 2024 04:44
@hoel-bagard hoel-bagard force-pushed the hoel/add_tf_saved_model branch from 037c132 to 3cbd71a Compare February 18, 2024 04:44

This comment has been minimized.

@hoel-bagard hoel-bagard marked this pull request as ready for review February 18, 2024 05:02

This comment has been minimized.

@hoel-bagard
Copy link
Contributor Author

@hmc-cs-mdrissi If you have time to have review it.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@hmc-cs-mdrissi hmc-cs-mdrissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks quite good.

This comment has been minimized.

1 similar comment
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit 56bb53a into python:main Mar 13, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants