-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tensorflow
add tensorflow.saved_model
#11439
Merged
JelleZijlstra
merged 19 commits into
python:main
from
hoel-bagard:hoel/add_tf_saved_model
Mar 13, 2024
Merged
tensorflow
add tensorflow.saved_model
#11439
JelleZijlstra
merged 19 commits into
python:main
from
hoel-bagard:hoel/add_tf_saved_model
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
hoel-bagard
force-pushed
the
hoel/add_tf_saved_model
branch
3 times, most recently
from
February 18, 2024 04:44
6037e52
to
037c132
Compare
hoel-bagard
force-pushed
the
hoel/add_tf_saved_model
branch
from
February 18, 2024 04:44
037c132
to
3cbd71a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@hmc-cs-mdrissi If you have time to have review it. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Mar 11, 2024
This comment has been minimized.
This comment has been minimized.
hmc-cs-mdrissi
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks quite good.
Co-authored-by: Jelle Zijlstra <[email protected]>
This comment has been minimized.
This comment has been minimized.
1 similar comment
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the stubs are taken from here.
All the members from the
tensorflow.python
module are causing the CI to fail sinceShould the whole
tensorflow.python
module be added to the allowlist ? I don't understand why the CI is fine with the othertensorflow.python
modules that are already in the stubs.